Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win library prefix #4

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Win library prefix #4

merged 5 commits into from
Aug 29, 2024

Conversation

JarrettSJohnson
Copy link
Contributor

Checklist

Fixes #3

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@JarrettSJohnson
Copy link
Contributor Author

@conda-forge-admin please rerender

@h-vetinari h-vetinari mentioned this pull request Aug 29, 2024
Merged
@h-vetinari
Copy link
Member

This was failing due to a gap between two different PRs that depended on each other. I've merged the second one now. In a couple hours, you can restart CI and it should pass.

@JarrettSJohnson
Copy link
Contributor Author

JarrettSJohnson commented Aug 29, 2024 •
edited
Loading

Ah, thanks @h-vetinari ; I just pushed a commit similar to this since I saw in the Elements chatroom they had the same issue as me. Just unfortunate timing I guess. I'll revert this and will rerun the CI tomorrow morning.

Thanks a bunch!

@JarrettSJohnson
Revert "Update meta.yaml"
6269ad9 
This reverts commit c72f901.
@JarrettSJohnson JarrettSJohnson marked this pull request as ready for review August 29, 2024 13:03
@vicentebolea
Copy link
Contributor

@JarrettSJohnson thanks for the contribution, please add in the description the reason of this change.

vicentebolea
vicentebolea approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks! no need to add the description, you had a link to the issue 🚀

@vicentebolea vicentebolea merged commit f1e47c8 into conda-forge:main Aug 29, 2024
5 checks passed
@JarrettSJohnson JarrettSJohnson deleted the win_library_prefix branch August 31, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicentebolea vicentebolea vicentebolea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vtk-m package installed in non-canonical location on Windows
3 participants
@JarrettSJohnson @h-vetinari @vicentebolea